Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose createEmailTemplate, getEmailTemplate, updateEmailTemplates vi… #416

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

rameshanandakrishnan
Copy link
Contributor

@rameshanandakrishnan rameshanandakrishnan commented Aug 22, 2019

Exposing emailTemplate endpoints via managmentClient

Changes

Exposing the email templates endpoint via ManagementClient

References

Issue #415

Testing

Not adding any new functionalities. Currently, the index file within the management folder does not have tests.

Checklist

@rameshanandakrishnan rameshanandakrishnan requested a review from a team August 22, 2019 13:11
Copy link
Contributor

@luisrudge luisrudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🎉 CAn you please add the tests for those endpoints as well?

@rameshanandakrishnan
Copy link
Contributor Author

@luisrudge Could you please review it again and let me know if you are happy with the changes?

@luisrudge luisrudge merged commit 851a45d into auth0:master Aug 27, 2019
@luisrudge
Copy link
Contributor

Thanks for the PR (and for pinging me) 🎉

@davidpatrick davidpatrick added this to the v2.20.0 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants